[Lldb-commits] [lldb] 809652c - Update TODO noting that DriverKit should be added too
Jason Molenda via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 6 20:12:28 PDT 2021
Author: Jason Molenda
Date: 2021-10-06T20:12:21-07:00
New Revision: 809652c93ba6b0fe6b01f935cc3da88d26a6714d
URL: https://github.com/llvm/llvm-project/commit/809652c93ba6b0fe6b01f935cc3da88d26a6714d
DIFF: https://github.com/llvm/llvm-project/commit/809652c93ba6b0fe6b01f935cc3da88d26a6714d.diff
LOG: Update TODO noting that DriverKit should be added too
When BridgeOS and DriverKit are added to llvm Triple.
Added:
Modified:
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Removed:
################################################################################
diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index e89cdb334009b..ff8e60df393f1 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -4997,10 +4997,14 @@ struct OSEnv {
case llvm::MachO::PLATFORM_WATCHOS:
os_type = llvm::Triple::getOSTypeName(llvm::Triple::WatchOS);
return;
- // NEED_BRIDGEOS_TRIPLE case llvm::MachO::PLATFORM_BRIDGEOS:
- // NEED_BRIDGEOS_TRIPLE os_type =
- // llvm::Triple::getOSTypeName(llvm::Triple::BridgeOS);
- // NEED_BRIDGEOS_TRIPLE return;
+ // TODO: add BridgeOS & DriverKit once in llvm/lib/Support/Triple.cpp
+ // NEED_BRIDGEOS_TRIPLE
+ // case llvm::MachO::PLATFORM_BRIDGEOS:
+ // os_type = llvm::Triple::getOSTypeName(llvm::Triple::BridgeOS);
+ // return;
+ // case llvm::MachO::PLATFORM_DRIVERKIT:
+ // os_type = llvm::Triple::getOSTypeName(llvm::Triple::DriverKit);
+ // return;
case llvm::MachO::PLATFORM_MACCATALYST:
os_type = llvm::Triple::getOSTypeName(llvm::Triple::IOS);
environment = llvm::Triple::getEnvironmentTypeName(llvm::Triple::MacABI);
More information about the lldb-commits
mailing list