[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:278
+    if (error.Fail())
+      return error;
+
----------------
JDevlieghere wrote:
> If this is the only way out of this loop, does that mean we always return an error here? 
In a previous diff, I stopped fetching memory regions if the `shared_ptr` was null, but now, I only have a memory region object instance which has no `IsValid` or `operator bool()` methods ... 

Not sure yet how I'll be able to fetch all the memory regions ... I'll have to rethink this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108953/new/

https://reviews.llvm.org/D108953