[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

Wed Oct 6 04:41:28 PDT 2021

mgorny marked an inline comment as done.
mgorny added inline comments.

================
Comment at: lldb/source/Plugins/ABI/X86/ABIX86.h:12

-#include "lldb/Target/ABI.h"
-
-class ABIX86 : public lldb_private::MCBasedABI {
+class ABIX86 {
 public:
----------------
labath wrote:
> Now it's weird that this class is in no relation to the ABI class, nor to the individual ABIXXX_YYY subclasses. Maybe lets insert it into the hierarchy (as a common superclass of ABIX86_i386 and ABIX86_64). Even if it's initially empty, I can imagine one could eventually put some common x86 code there.
Sure, will do.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111216/new/

https://reviews.llvm.org/D111216