[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

Tue Oct 5 06:48:05 PDT 2021

mgorny added a comment.

In D110962#3042270 <https://reviews.llvm.org/D110962#3042270>, @davezarzycki wrote:

> errno == 22 (EINVAL)
>
> The FD in question is 3. Here is the output from `lsof`: HostTests 80108 dave    3u   CHR    5,2      0t0       231 /dev/ptmx

I don't think FD is the problem — requests for the same `fd` don't fail above. I think it's some `terminfo` flags.

> Can we/I please revert this for now?

Feel free to revert if you're going to help me fix it afterwards. It doesn't fail here nor on the buildbot.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110962/new/

https://reviews.llvm.org/D110962