[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357
 
         assert(reg_info.byte_size != 0);
         registers.push_back(reg_info);
----------------
omjavaid wrote:
> @mgorny the assert already exists but then we also want to allow bit sized registers although they ll be viewed as byte length for now.
Ah, right. I suppose you could skip zero-byte registers though. That should amend the assert with better release behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111131/new/

https://reviews.llvm.org/D111131