[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 5 03:39:13 PDT 2021


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4261
+              reg_info.byte_size =
+                  (reg_info.byte_size + CHAR_BIT - 1) / CHAR_BIT;
           } else if (name == "type") {
----------------
I suppose LLDB crashed because `byte_size` was zero? Maybe add an assert for that then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111131/new/

https://reviews.llvm.org/D111131



More information about the lldb-commits mailing list