[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

Tue Oct 5 01:05:30 PDT 2021

labath added inline comments.

================
Comment at: lldb/include/lldb/Target/ABI.h:131-134
   virtual void AugmentRegisterInfo(RegisterInfo &info) = 0;
+  // Routine called before DynamicRegisterInfo::Finalize().
+  virtual void
+  PreFinalizeDynamicRegisterInfo(lldb_private::DynamicRegisterInfo &info) {}
----------------
Ideally, I would like to subsume the `AugmentRegisterInfo` functionality into this function, so that one would just call `abi->Augment(Dynamic)RegisterInfo(dyn_reg_info)` and it would automatically fill it in with all the necessary information. The old `AugmentRegisterInfo` function could become a private/protected implementation detail.

Would such a thing be possible? Perhaps with some preparatory refactoring patch?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109876/new/

https://reviews.llvm.org/D109876