[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

Mon Oct 4 23:46:39 PDT 2021

labath accepted this revision.
labath added a comment.

Let's ship this.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3545
+
+DIEVector MergeBlockAbstractParameters(const DWARFDIE &block_die,
+                                       DIEVector &&variable_dies) {
----------------
jarin wrote:
> labath wrote:
> > In llvm, we prefer `static` functions over anonymous namespaces. Theoretically, you could keep the anonymous namespace around the using declaration (per <https://llvm.org/docs/CodingStandards.html#anonymous-namespaces>, as those can't use `static`), though I would actually probably prefer  DIEArray type defined in DIERef.h over a custom type.
> Changed to static function, DIEArray (interestingly, this file actually starts with anonymous namespace, see line 121).
We're not always very good at following llvm policies, although I would say that this particular namespace is mostly ok-ish -- it mostly contains type declarations (classes, enums), where `static` does not work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110571/new/

https://reviews.llvm.org/D110571