[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 4 10:55:35 PDT 2021


JDevlieghere added a comment.

I'm slightly worried about the switch from a unique pointer to a shared pointer. It seems like a memory region is a simple enough object that it's warranted to make a copy to avoid this change. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108953/new/

https://reviews.llvm.org/D108953



More information about the lldb-commits mailing list