[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Have you considered using the PseudoTerminal class to create the ptys ?



================
Comment at: lldb/unittests/Host/CMakeLists.txt:27
+if (LLDB_ENABLE_TERMIOS AND
+    CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|Linux|NetBSD|OpenBSD")
+  list(APPEND FILES
----------------
mgorny wrote:
> FTR, I've tested it on FreeBSD and Linux so far. NetBSD in progress. Darwin and OpenBSD support is based on what I've found in gnulib but explicit testing would be helpful.
At this point, I'd just go with `NOT windows`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110962/new/

https://reviews.llvm.org/D110962