[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 2 inline comments as done.
mgorny added a comment.

In D110721#3035879 <https://reviews.llvm.org/D110721#3035879>, @labath wrote:

> Is anyone passing save_process_group = true now? If not, I'd really like to delete it, as the implementation is quite scary.

Yes, `Debugger::SaveInputTerminalState()` does.



================
Comment at: lldb/source/Host/common/Terminal.cpp:92
+    : m_tty(term) {
+  Save(term, save_process_group);
 }
----------------
labath wrote:
> Could we make `Save` private now? Or even inline it into the constructor ?
Unfortunately, no. `Debugger` still manually saves/restores.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110721/new/

https://reviews.llvm.org/D110721