[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

Thu Sep 30 14:48:00 PDT 2021

JDevlieghere added a comment.

In D110804#3034878 <https://reviews.llvm.org/D110804#3034878>, @clayborg wrote:

> I would like to get a consensus on if we should move this functionality to "statistics" or not. The reasons that I didn't do it were:
>
> - "statistics" as a top level method doesn't really do what I wanted here, which was "target statistics", or stats that are related only to the current target. I am not all that interested in overall stats over all targets

How about we keep the statistics as a top-level entity (even above the debugger) and then have have the equivalent of metrics per debugger and per target? You can define different metrics at different levels. The commands could remain as is, where `target metrics` (or ` target statistics`) dumps the metrics for the current target and the old statistics dumps the JSON for everything hierarchically.

> - I didn't want to have to make a human readable and JSON output

I'm not interested in human readable output either. For our purposes JSON only is fine. If we considered removing the statistics altogether I  don't think anyone will miss the current human readable output?

> - the "statistics enable"/"statistics disable" didn't seem to make sense as they were coded in top of tree. Maybe enabling and disabling makes more sense when more info is gathered in hidden patches that have not been upstreamed?

I see two potential use cases for enabling/disabling statistics:

- The most obvious one being a way to work around a bug or performance overhead caused by collecting the statistics.
- The data that's being collected could serve as the basis for something like anonymous analytics. Enabling/disabling the statistics could be a way to opt-in or out from this data being automatically collected and shared.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110804/new/

https://reviews.llvm.org/D110804