[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

Thu Sep 30 08:39:04 PDT 2021

JDevlieghere added a comment.

In D110804#3032741 <https://reviews.llvm.org/D110804#3032741>, @labath wrote:

> I have a feeling that there's a lot of overlap between this and the "statistics" command. As a user, I don't think I would be able to tell the difference between these two things.
>
> Having two systems which do vaguely similar things does not seem like a good idea. Have you considered unifying them? Or maybe just deleting the old one, if its not used (I don't think it has gotten any improvements since it was initially introduced)?

+1 on unifying the two.

In D110804#3032881 <https://reviews.llvm.org/D110804#3032881>, @teemperor wrote:

> +Vedant who had/has some plans with the statistics command at some point IIRC.
>
> FWIW, I wanted to throw away the current statistics implementation for quite a while but I didn't have anything to replace it with. If we can replace it with this then that would be nice.

We have (short term) plans to start using the statistics to collect more data. Vedant created some patches last year that I've rebased but haven't landed yet. I'll try to get these up on Phabricator ASAP. They're not that invasive, expect maybe the decision to move the statistics above the debugger level. That's something we need to capture things like how many lldb_asserts we've hit in a release build, as well as other metrics that span multiple debuggers (a common use case in Xcode).  We're mostly interested in capturing how often something happens as opposed to how long something took (like in this patch) but I think there's room for both in the unified solution.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110804/new/

https://reviews.llvm.org/D110804