[Lldb-commits] [PATCH] D110721: [lldb] [Host] Merge TerminalState into Terminal

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 29 08:10:10 PDT 2021


mgorny created this revision.
mgorny added reviewers: labath, teemperor, emaste, krytarowski.
mgorny requested review of this revision.

Merge the routines from the TerminalState class into Terminal.  There
does not seem to be a real advantage from having the two classes split,
and the TerminalState class has a weird API.  It uses the Terminal class
internally but neither accepts its instance as an argument, nor exposes
the internal instance to the caller.  As a result, some callers ended up
combining Terminal and TerminalState classes (effectively having two
Terminal classes).


https://reviews.llvm.org/D110721

Files:
  lldb/include/lldb/Core/Debugger.h
  lldb/include/lldb/Host/Terminal.h
  lldb/source/Core/Debugger.cpp
  lldb/source/Host/common/Terminal.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h
  lldb/source/Target/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110721.375897.patch
Type: text/x-patch
Size: 11504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210929/f87c823f/attachment-0001.bin>


More information about the lldb-commits mailing list