[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

[Jaroslav Sevcik via Phabricator via lldb-commits]

jarin updated this revision to Diff 375865.
jarin added a comment.

Rewrote the recursive parser to use a plain method.

Pruned and annotated the test.

Added other test cases:

- all parameters unused,
- inlining from two different functions,
- stack trace.

This still uses `frame variable` rather than `image lookup`, mostly because `frame variable` tests better the user experience and the cognitive overhead for making the code runnable does not seem to be too high.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110571/new/

https://reviews.llvm.org/D110571

Files:
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  lldb/test/Shell/SymbolFile/DWARF/x86/Inputs/unused-inlined-params.s
  lldb/test/Shell/SymbolFile/DWARF/x86/unused-inlined-params.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110571.375865.patch
Type: text/x-patch
Size: 30883 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210929/f895af32/attachment-0001.bin>