[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good to me, but I'd give @joerg a chance to respond first.

In D110535#3028450 <https://reviews.llvm.org/D110535#3028450>, @joerg wrote:

> Why are all the changes from separator character to separator string necessary or desirable?

There's no good place to store the separator character. The functional version of split is implemented by creating a `StringRef(&the_char, 1)`, but that won't work in the iterator version. Keeping it doesn't seem to be worth the trouble, as it does not have any performance benefits,  and doesn't make the callsites more complicated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110535/new/

https://reviews.llvm.org/D110535