[Lldb-commits] [PATCH] D110619: [lldb] [DynamicRegisterInfo] Refactor SetRegisterInfo()

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:244
+              ? ByteOffsetFromSlice(i, slice_str, byte_order)
+          : reg_info_dict->GetValueForKeyAsArray("composite",
+                                                 composite_reg_list)
----------------
labath wrote:
> mgorny wrote:
> > clang-format seems to indent this weirdly.
> I can't say I blame it. :)
> 
> Maybe make this a separate function too, so you can use ifs and returns ?
I didn't like this idea at first, then realized I can move the `offset` getter there too, and this makes everything even nicer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110619/new/

https://reviews.llvm.org/D110619