[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 28 04:31:38 PDT 2021


labath added a comment.

The patch seems reasonable to me, and is an improvement over the status quo.

The thing I'm left wondering is the lambda in `ParseVariablesInFunctionContext`. It covers like 95% of the enclosing function. Could we just make a separate method for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110570/new/

https://reviews.llvm.org/D110570



More information about the lldb-commits mailing list