[Lldb-commits] [PATCH] D110472: [lldb] [gdb-remote] Use llvm::StringRef.split() and llvm::to_integer()

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1667
+            addr_t page;
+            if (llvm::to_integer(x, page))
               dirty_page_list.push_back(page);
----------------
mgorny wrote:
> mgorny wrote:
> > teemperor wrote:
> > > Base 16 arg is lost here.
> > Good catch, thanks.
> Actually, scratch that. The values here include `0x` prefix. and apparently `llvm::to_integer()` handles that correctly only if base isn't specified.
> 
> Though it might be reasonable to fix `llvm::to_integer()` to allow matching prefix, I guess.
I've pinged @labath about this and he suggested just stripping the `0x` prefix (and fixing the sender not to send it). I'll do the first part in this patch, and then look into updating the code and docs to rid of `0x` prefix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110472/new/

https://reviews.llvm.org/D110472