[Lldb-commits] [PATCH] D110410: [lldb] [Host] Refactor XML converting getters

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere.
mgorny requested review of this revision.

Refactor the XML converting attribute and text getters to use LLVM API.
While at it, remove some redundant error and missing XML support
handling, as the called base functions do that anyway.  Add tests
for these methods.

Note that this patch changes the getter behavior to be IMHO more
correct.  In particular:

- negative and overflowing integers are now reported as failures to convert, rather than being wrapped over or capped

- digits followed by text are now reported as failures to convert to double, rather than their numeric part being converted


https://reviews.llvm.org/D110410

Files:
  lldb/source/Host/common/XML.cpp
  lldb/unittests/Host/CMakeLists.txt
  lldb/unittests/Host/XMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110410.374821.patch
Type: text/x-patch
Size: 6800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210924/f692baa7/attachment.bin>