[Lldb-commits] [PATCH] D109231: [lldb] Improve error handling around GetRngListData()

[Kim-Anh Tran via Phabricator via lldb-commits]

kimanh added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:522
+            entry->getContribution(llvm::DW_SECT_RNGLISTS)) {
+      Offset = contribution->Offset;
       return DWARFDataExtractor(data, contribution->Offset,
----------------
shafik wrote:
> If I am reading this correctly, it looks like this will only be set on the non-error case which will leave `contribution_off` in the caller uninitialized in the cases you care about logging.
Sorry for the very late reply (I had a long vacation)! And thanks for the comment.

If `GetRnglistData` didn't work, the error will be thrown below (line 526) in here. However, if it is successful, but another problem occurs (callers of `GetRnglistData` throw an error) the Offset will be initialized, and it can be logged. Example: `ParseListTableHeader` using it in ll. 548. Does that make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109231/new/

https://reviews.llvm.org/D109231