[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

[Emre Kultursay via Phabricator via lldb-commits]

emrekultursay marked 3 inline comments as done.
emrekultursay added a comment.

PTAL. The test now passes on Linux, MacOS, and Windows.



================
Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26
+  // dlopen the 'liblib_b.so' shared library.
+  void* h = dlopen(solib, RTLD_LAZY);
+  assert(h && "dlopen failed?");
----------------
labath wrote:
> see dylib.h and the functions within (the inferior of TestLoadUnload uses them) for a windows-compatible way to load shared libraries.
Since we are attaching to an already running process, which cannot find the dynamic library unless I pass the full path to `dlopen()`. That's why I couldn't use dylib.h (which doesn't add full path), but created my own version here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109797/new/

https://reviews.llvm.org/D109797