[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The SymbolFile/PDB tests are supposed to specifically test the (non-native) pdb plugin, so disabling them in this mode makes perfect sense to me. (though someone interested in pdb support may want to take a look at them to see whether they are failing just because they are testing some specific behavior of the non-native plugin, or because they are exposing some bugs in the native version).

That leaves us with just three tests. I'm not sure what's the deal with TestSingleQuote.test, but I think it could be just some simple bug, where the code balks at a filename with quotes in it. I have no idea what's the deal with the other two. The stack unwinding failure is particularly strange, as that one already forces the use of the native reader.

Is there any chance someone could take a look at those?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109834/new/

https://reviews.llvm.org/D109834