[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

In D109928#3013627 <https://reviews.llvm.org/D109928#3013627>, @shafik wrote:

> I think this looks fine, just verify that this in a C++ case an expression with an `extern "C"` function call works fine e.g.
>
>   extern "C" {
>     int g() { return 10;}
>   }
>   
>   int main() {
>      return g();  // break here and run expr g()
>   }
>
> I discovered the other day that we mangle `extern "C"` functions in C++ mode and I have a fix I wanted to run by everyone but I have not had a chance to do it yet.
>
> So this case get resolved in `CollectFallbackNames(...)`.

I believe this is already covered by `TestExternCSymbols.py` in `test/API/cpp/extern_c/`. `CollectFallbackNames` did correctly resolve this case, so I made sure this change didn't break that test.

Anything you think I should change or is this good to go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109928/new/

https://reviews.llvm.org/D109928