[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 20 04:10:07 PDT 2021
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:384
+ def qSupported(self, client_supported):
+ assert "multiprocess+" in client_supported
+ return "multiprocess+;" + super().qSupported(client_supported)
----------------
Whether this fires depends on how python was run. Better use regular asserts. You could pass in the test case to MyResponder constructor, or stash client_supported in a member variable for later checks, or ...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110033/new/
https://reviews.llvm.org/D110033
More information about the lldb-commits
mailing list