[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:482
+    // copy invalidate_regs from the parent register
+    llvm::append_range(to_add[reg_num], m_invalidate_regs_map[value_reg]);
+
----------------
mgorny wrote:
> @labath, any suggestion how to do this nicely while not copying the terminating `LLDB_INVALID_REGNUM`?
How about by making sure that `LLDB_INVALID_REGNUM` is not present in the firstplace (by adding it only during finalization)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110023/new/

https://reviews.llvm.org/D110023