[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()
    Pavel Labath via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Mon Sep 20 00:22:21 PDT 2021
    
    
  
labath added a comment.
As I alluded to in the second comment, I'm not sure this is really that much helpful, since it's also nice to have all invalidate_regs handling happen in a single function. Maybe AddRegister should just set this field to null (to give a more predictable behavior (crash) if anyone accesses it), and have a comment saying that it will be filled in in `Finalize` ?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109879/new/
https://reviews.llvm.org/D109879
    
    
More information about the lldb-commits
mailing list