[Lldb-commits] [PATCH] D110025: [lldb] [gdb-remote] Refactor getting remote regs to use local vector [WIP]

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 20 00:12:33 PDT 2021


labath added a comment.

I like it.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4368-4371
+namespace lldb_private {
+namespace process_gdb_remote {
+
+struct RemoteRegisterInfo {
----------------
`struct process_gdb_remote::RemoteRegisterInfo {` should work too. Putting the declaration in the header would also be ok.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110025/new/

https://reviews.llvm.org/D110025



More information about the lldb-commits mailing list