[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4267-4270
+    if (!StateIsStoppedState(process_state, true)) {
+      result.AppendErrorWithFormat("process is not stopped: %s",
+                                   StateAsCString(process_state));
+    }
----------------
Is this missing a `return`?


================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4280-4281
+    uint32_t frame_count = thread->GetStackFrameCount();
+    for (uint32_t i = 0; i < frame_count; ++i) {
+      lldb::StackFrameSP frame_sp = thread->GetStackFrameAtIndex(i);
+
----------------
we don't have an iterator for this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110011/new/

https://reviews.llvm.org/D110011