[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

[Ted Woodward via Phabricator via lldb-commits]

ted added a comment.

I agree about the test. I'll work on one.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2911-2912
+            // if ids is empty, this is an error
+            if (ids.size() == 0)
+              return {};
+            // if ids is not empty, bail out from here and process ids
----------------
labath wrote:
> Isn't it still possible to get the infinite recursion you mentioned, if the response consists only of a single comma ?
Yes. I was wondering if the correct response to this case is to drop down and go through the "pid=tid=1" case from line 2931. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109937/new/

https://reviews.llvm.org/D109937