[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

We should make a test for this.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2909-2917
+          if (!pid_tid) {
+            // if ids is empty, this is an error
+            if (ids.size() == 0)
+              return {};
+            // if ids is not empty, bail out from here and process ids
+            break;
+          }
----------------
Might be nice to make sure we got LLDB_INVALID_PROCESS_ID back, as it might not always be zero?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109937/new/

https://reviews.llvm.org/D109937