[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks fine to me. I am assuming the full test suite passes with this change in place?



================
Comment at: lldb/source/Expression/IRExecutionUnit.cpp:717
+          if (ConstString best_alternate_mangled_name =
+                  FindBestAlternateMangledName(demangled, sc))
+            CPP_names.push_back(best_alternate_mangled_name);
----------------
Seems like we should be passing in the "Mangled" object into "FindBestAlternateMangledName" in case it has extra information. For example constructors and destructors have many different types (in charge, not in charge, etc).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109928/new/

https://reviews.llvm.org/D109928