[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130
 
-  // Given a mangled function name, calculates some alternative manglings since
-  // the compiler mangling may not line up with the symbol we are expecting
-  static uint32_t
-  FindAlternateFunctionManglings(const ConstString mangled,
-                                 std::set<ConstString> &candidates);
+  std::set<ConstString>
+  GenerateAlternateFunctionManglings(const ConstString mangled) const override;
----------------
clayborg wrote:
> Do we need to be using a std::set? Do we need this to be an ordered result? I would think a std::vector would be better no?
I'm not sure why it was a `std::set` to begin with but I don't see any reason why it can't be a `std::vector` instead. I'll update this before I land it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109785/new/

https://reviews.llvm.org/D109785