[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

[Nico Weber via Phabricator via lldb-commits]

thakis created this revision.
thakis added a reviewer: amccarth.
thakis requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Before this change, running check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO would fail ~25 tests.

This change adds a lit feature based on if the DIA SDK is available and annotates
all tests that set breakpoints with this new feature. Now these tests are skipped
(with a warning message during test startup) instead of failing. This matches how
this is handled in check-llvm.

(This doesn't touch API or Unit tests for now.)


https://reviews.llvm.org/D109834

Files:
  lldb/test/Shell/Breakpoint/case-insensitive.test
  lldb/test/Shell/Breakpoint/dummy-target.test
  lldb/test/Shell/Commands/command-thread-select.test
  lldb/test/Shell/Driver/TestSingleQuote.test
  lldb/test/Shell/Expr/TestIRMemoryMapWindows.test
  lldb/test/Shell/Expr/nodefaultlib.cpp
  lldb/test/Shell/Settings/TestFrameFormatColor.test
  lldb/test/Shell/Settings/TestFrameFormatNoColor.test
  lldb/test/Shell/Settings/TestLineMarkerColor.test
  lldb/test/Shell/SymbolFile/NativePDB/stack_unwinding01.cpp
  lldb/test/Shell/SymbolFile/PDB/lit.local.cfg
  lldb/test/Shell/Watchpoint/SetErrorCases.test
  lldb/test/Shell/lit.cfg.py
  lldb/test/Shell/lit.site.cfg.py.in
  llvm/utils/gn/secondary/lldb/test/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109834.372719.patch
Type: text/x-patch
Size: 7373 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210915/f94e1867/attachment.bin>