[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/include/lldb/Target/AppleArm64ExceptionClass.h:14
+
+enum class AppleArm64ExceptionClass : unsigned {
+#define APPLE_ARM64_EXCEPTION_CLASS(Name, Code) Name = Code,
----------------
We should use fixed sized integer types whenever possible, I suppose in this case `uint32_t`.


================
Comment at: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp:111
+          uint32_t esr_val = esr.GetAsUInt32();
+          auto exception_class =
+              static_cast<AppleArm64ExceptionClass>(esr_val >> 26);
----------------
`const`


================
Comment at: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp:112
+          auto exception_class =
+              static_cast<AppleArm64ExceptionClass>(esr_val >> 26);
+          if (exception_class !=
----------------
Does `26` have a meaning? I am guessing we are shifting to get the EC bits?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109795/new/

https://reviews.llvm.org/D109795