[Lldb-commits] [PATCH] D109779: [LLDB] [Minidump] Fix format string warnings on Windows

Fangrui Song via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 14 13:54:26 PDT 2021


MaskRay added a comment.

I fixed this in e69d359841b6358f1d17569212ef8cf91244ca11 <https://reviews.llvm.org/rGe69d359841b6358f1d17569212ef8cf91244ca11> and fixed some style issues.

---

This needs extra care.

While Clang -Wformat flags

  printf("%llu", (size_t)3);
  
  warning: format specifies type 'unsigned long long' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]

This is silent:

  printf("%ld", (size_t)3);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109779/new/

https://reviews.llvm.org/D109779



More information about the lldb-commits mailing list