[Lldb-commits] [PATCH] D109778: [lldb] [Windows] Fix an incorrect assert in NativeRegisterContextWindows_arm

Martin Storsjö via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 14 12:17:46 PDT 2021


mstorsjo created this revision.
mstorsjo added a reviewer: labath.
Herald added a subscriber: kristof.beyls.
mstorsjo requested review of this revision.
Herald added a project: LLDB.

This codepath hadn't been exercised in a build with asserts before.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109778

Files:
  lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp


Index: lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp
===================================================================
--- lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp
+++ lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp
@@ -80,8 +80,8 @@
 
 static RegisterInfoInterface *
 CreateRegisterInfoInterface(const ArchSpec &target_arch) {
-  assert((HostInfo::GetArchitecture().GetAddressByteSize() == 8) &&
-         "Register setting path assumes this is a 64-bit host");
+  assert((HostInfo::GetArchitecture().GetAddressByteSize() == 4) &&
+         "Register setting path assumes this is a 32-bit host");
   return new RegisterInfoPOSIX_arm(target_arch);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109778.372533.patch
Type: text/x-patch
Size: 760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210914/0d24b1fa/attachment.bin>


More information about the lldb-commits mailing list