[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:120
+  if (error.Fail()) {
+    error.SetErrorString("Unable to convert the csd string to UTF16.");
+    return error;
----------------
https://llvm.org/docs/CodingStandards.html#error-and-warning-messages

Don't capitalize messages and don't append `.`


================
Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:732
+      error.SetErrorStringWithFormat(
+          "Unable to write the header. (written %ld/%ld).", bytes_written,
+          header_size);
----------------
The format specifiers are wrong. size_t should use %zd and one uint64_t below should use PRIu64.

I have fixed them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108233/new/

https://reviews.llvm.org/D108233