[Lldb-commits] [lldb] c4fa2c8 - [lldb] Fix warning in MinidumpFileBuilder.cpp

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 13 10:42:09 PDT 2021


Author: Alex Langford
Date: 2021-09-13T10:37:45-07:00
New Revision: c4fa2c8aa493e4c786446739ba3eb0eb4918d579

URL: https://github.com/llvm/llvm-project/commit/c4fa2c8aa493e4c786446739ba3eb0eb4918d579
DIFF: https://github.com/llvm/llvm-project/commit/c4fa2c8aa493e4c786446739ba3eb0eb4918d579.diff

LOG: [lldb] Fix warning in MinidumpFileBuilder.cpp

Fixes the following warning:

$llvm_project/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:744:11: warning:
format specifies type 'long' but the argument has type 'lldb::offset_t' (aka 'unsigned long long') [-Wformat]
          m_data.GetByteSize());
          ^~~~~~~~~~~~~~~~~~~~

Added: 
    

Modified: 
    lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
index 1f9c96013ebff..03722b391004f 100644
--- a/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
+++ b/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
@@ -740,7 +740,7 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
   if (error.Fail() || bytes_written != m_data.GetByteSize()) {
     if (bytes_written != m_data.GetByteSize())
       error.SetErrorStringWithFormat(
-          "Unable to write the data. (written %ld/%ld).", bytes_written,
+          "Unable to write the data. (written %ld/%llu).", bytes_written,
           m_data.GetByteSize());
     return error;
   }
@@ -767,4 +767,4 @@ size_t MinidumpFileBuilder::GetDirectoriesNum() const {
 
 size_t MinidumpFileBuilder::GetCurrentDataEndOffset() const {
   return sizeof(llvm::minidump::Header) + m_data.GetByteSize();
-}
\ No newline at end of file
+}


        


More information about the lldb-commits mailing list