[Lldb-commits] [lldb] dd58083 - [lldb] [test] Remove parent output checks from follow-child tests

Michał Górny via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 13 06:50:11 PDT 2021


Author: Michał Górny
Date: 2021-09-13T15:50:00+02:00
New Revision: dd5808330484ad3b82ba92ae1a249127b0e0bbb4

URL: https://github.com/llvm/llvm-project/commit/dd5808330484ad3b82ba92ae1a249127b0e0bbb4
DIFF: https://github.com/llvm/llvm-project/commit/dd5808330484ad3b82ba92ae1a249127b0e0bbb4.diff

LOG: [lldb] [test] Remove parent output checks from follow-child tests

Remove the parent output checks, as they make the test flaky while
serving no real purpose.  If the parent crashed/hanged, it will never
resume the child and the test would fail anyway.

Added: 
    

Modified: 
    lldb/test/Shell/Subprocess/clone-follow-child-wp.test
    lldb/test/Shell/Subprocess/clone-follow-child.test
    lldb/test/Shell/Subprocess/fork-follow-child-softbp.test
    lldb/test/Shell/Subprocess/fork-follow-child-wp.test
    lldb/test/Shell/Subprocess/fork-follow-child.test
    lldb/test/Shell/Subprocess/vfork-follow-child-softbp.test
    lldb/test/Shell/Subprocess/vfork-follow-child-wp.test
    lldb/test/Shell/Subprocess/vfork-follow-child.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/Subprocess/clone-follow-child-wp.test b/lldb/test/Shell/Subprocess/clone-follow-child-wp.test
index 325316867f1ad..6238d54237610 100644
--- a/lldb/test/Shell/Subprocess/clone-follow-child-wp.test
+++ b/lldb/test/Shell/Subprocess/clone-follow-child-wp.test
@@ -9,7 +9,6 @@ process launch -s
 watchpoint set variable -w write g_val
 # CHECK: Watchpoint created:
 continue
-# CHECK: function run in parent
 # CHECK: stop reason = watchpoint
 continue
 # CHECK: stop reason = watchpoint

diff  --git a/lldb/test/Shell/Subprocess/clone-follow-child.test b/lldb/test/Shell/Subprocess/clone-follow-child.test
index 0d17b81e697f8..dbdb580637cd0 100644
--- a/lldb/test/Shell/Subprocess/clone-follow-child.test
+++ b/lldb/test/Shell/Subprocess/clone-follow-child.test
@@ -7,5 +7,4 @@ settings set target.process.follow-fork-mode child
 settings set target.process.stop-on-exec false
 b parent_func
 process launch
-# CHECK: function run in parent
 # CHECK: function run in exec'd child

diff  --git a/lldb/test/Shell/Subprocess/fork-follow-child-softbp.test b/lldb/test/Shell/Subprocess/fork-follow-child-softbp.test
index 7129d7b682c56..d07ea3bbda993 100644
--- a/lldb/test/Shell/Subprocess/fork-follow-child-softbp.test
+++ b/lldb/test/Shell/Subprocess/fork-follow-child-softbp.test
@@ -8,7 +8,6 @@ settings set target.process.stop-on-exec false
 b child_func
 b parent_func
 process launch
-# CHECK: function run in parent
 # CHECK: stop reason = breakpoint
 # CHECK-NEXT: child_func
 continue

diff  --git a/lldb/test/Shell/Subprocess/fork-follow-child-wp.test b/lldb/test/Shell/Subprocess/fork-follow-child-wp.test
index f0de4a4deb501..77b442c078af9 100644
--- a/lldb/test/Shell/Subprocess/fork-follow-child-wp.test
+++ b/lldb/test/Shell/Subprocess/fork-follow-child-wp.test
@@ -9,7 +9,6 @@ process launch -s
 watchpoint set variable -w write g_val
 # CHECK: Watchpoint created:
 continue
-# CHECK: function run in parent
 # CHECK: stop reason = watchpoint
 continue
 # CHECK: stop reason = watchpoint

diff  --git a/lldb/test/Shell/Subprocess/fork-follow-child.test b/lldb/test/Shell/Subprocess/fork-follow-child.test
index c401e15288811..45bdf7ad6e870 100644
--- a/lldb/test/Shell/Subprocess/fork-follow-child.test
+++ b/lldb/test/Shell/Subprocess/fork-follow-child.test
@@ -7,5 +7,4 @@ settings set target.process.follow-fork-mode child
 settings set target.process.stop-on-exec false
 b parent_func
 process launch
-# CHECK: function run in parent
 # CHECK: function run in exec'd child

diff  --git a/lldb/test/Shell/Subprocess/vfork-follow-child-softbp.test b/lldb/test/Shell/Subprocess/vfork-follow-child-softbp.test
index c82a4f6cdc745..ac07ee67aedc7 100644
--- a/lldb/test/Shell/Subprocess/vfork-follow-child-softbp.test
+++ b/lldb/test/Shell/Subprocess/vfork-follow-child-softbp.test
@@ -8,5 +8,4 @@ settings set target.process.stop-on-exec false
 b child_func
 b parent_func
 process launch
-# CHECK: function run in parent
 # CHECK: function run in exec'd child

diff  --git a/lldb/test/Shell/Subprocess/vfork-follow-child-wp.test b/lldb/test/Shell/Subprocess/vfork-follow-child-wp.test
index 2de3229bfcad9..548a089cd4fa4 100644
--- a/lldb/test/Shell/Subprocess/vfork-follow-child-wp.test
+++ b/lldb/test/Shell/Subprocess/vfork-follow-child-wp.test
@@ -9,5 +9,4 @@ process launch -s
 watchpoint set variable -w write g_val
 # CHECK: Watchpoint created:
 continue
-# CHECK: function run in parent
 # CHECK: function run in exec'd child

diff  --git a/lldb/test/Shell/Subprocess/vfork-follow-child.test b/lldb/test/Shell/Subprocess/vfork-follow-child.test
index 833fbb8837afd..3237cb1ea2ebc 100644
--- a/lldb/test/Shell/Subprocess/vfork-follow-child.test
+++ b/lldb/test/Shell/Subprocess/vfork-follow-child.test
@@ -7,5 +7,4 @@ settings set target.process.follow-fork-mode child
 settings set target.process.stop-on-exec false
 b parent_func
 process launch
-# CHECK: function run in parent
 # CHECK: function run in exec'd child


        


More information about the lldb-commits mailing list