[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

I should note two more things.  First, I make this code which was previously checking if the ObjectFile was a memory image unconditional if the dSYM's segment file address differs from the ObjectFile's segment file address.  I can't see how this is possible in any case but a shared cache -- so I could check that the ObjectFile is in the shared cache -- but however we got to this point, the only correct thing to do is to use the dSYM (SymbolFile)'s file addresses, it's immaterial.

Second, man, I can't think of a way to test this.  You need to be adding a dSYM to a binary in the system's shared cache on a darwin system.  We have access to the dSYMs for system binaries inside Apple, but we can't use those for automated testing in any way, and which dSYM you need depends on the system.  This is a drag because this regression has snuck past us at least once in the past too, looking over the history of the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108889/new/

https://reviews.llvm.org/D108889