[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

Wed Aug 25 18:01:28 PDT 2021

bulbazord added a comment.

In D108229#2966405 <https://reviews.llvm.org/D108229#2966405>, @aprantl wrote:

> FYI (you may have have already noticed) this causes some merge conflicts in swift-lldb. It would be great if we could work together to figure out how to best resolve them.

Yes, I figured that would happen at some point. I have an interest in seeing swift-lldb apply this change (and some of my other refactoring patches) so I would love to work with you and anyone else to get this change in smoothly. Unfortunately I had to revert this patch. It appears my environment had some issues that prevented me from running about half of lldb's test suite so I didn't catch any of the failures. I was finally able to debug the failing tests today and I realized that this change has several issues that need to be addressed. Once I have time to work through those issues and resubmit this patch, I'll add you as a reviewer and we can go from there. Does this sound good to you?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108229/new/

https://reviews.llvm.org/D108229