[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

In D108717#2965815 <https://reviews.llvm.org/D108717#2965815>, @teemperor wrote:

> Thanks for the patch!
>
> So IIUC correctly this fixes a crash when calling `Dereference` on an SBValue that is of type `SomeTypedef` with `typedef int& SomeTypedef`? If yes, then I think the test here could just be another type+assert in `TestCPPDereferencingReferences.py`. The test here is a bit expensive and seems to depend on a specific libc++ version (-> it will also always pass on Linux), even though this is just a TypeSystemClang patch.

Let me see if I can mock up a test using that and if so that would definitely be nicer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108717/new/

https://reviews.llvm.org/D108717