[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:73
+  llvm::StringRef basename = method.GetBasename();
+  if (basename.empty()) {
+    if (CPlusPlusLanguage::ExtractContextAndIdentifier(
----------------
jingham wrote:
> The old code checked method.IsValid before pulling out the base name.  It seems sensible that an invalid MethodName would return an empty base name, but that does seem to rely a little on implicit behavior?  Not sure that's a big deal.
Yep, this does rely on implicit behavior. I don't think it's a huge deal, but it's easily changeable. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108229/new/

https://reviews.llvm.org/D108229