[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

[Omar Emara via Phabricator via lldb-commits]

OmarEmaraDev added inline comments.


================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3592
+        m_selected_match(0), m_first_visible_match(0) {
+    ;
+  }
----------------
OmarEmaraDev wrote:
> clayborg wrote:
> > Should we be doing just like any other dialog that we have created and be constructing these items on the fly?
> > 
> > ```
> > m_text_field = AddTextField("Search", "", true);
> > ```
> > It seems the matches could use a modified ChoicesField for the matches? Are you currently drawing the choices (matches) manually?
> `AddTextField` is part of form delegates, I don't think implementing this as a form is a good idea as they are functionally distinct.
> 
> I am drawing choices manually because the duplicated code is not really a lot and I like to be able to control the style of the drawing. But I guess we can reimplemented that using a choices field.
One thing to note is that text representation of matches are lazily computed in this window but not in the choices field, which gives an advantage. We can probably add support for lazy computation in the choice field, but it may not be worth it at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108545/new/

https://reviews.llvm.org/D108545