[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

I'm very supportive of the idea that we delete everything that isn't tested :) (and I'm only partly joking here). However removing this should cause a bunch of test failures on Linux as it effectively disables D70721 <https://reviews.llvm.org/D70721> (the test added in that patch was just a unit test that is preserved with this patch, but the bigger problem describes there will break a few tests calling constructors on Linux).

I believe the usual 'iterate over all language plugins' approach would again work here? We can guess from the mangled symbol what language we deal with (and in the worst case we could encode that in the IRExecutionUnit), so the plugins would just deliver alternative names. `GetAlternativeSymbolNames(ConstString symbol)` or something like that maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108395/new/

https://reviews.llvm.org/D108395