[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

[Kim-Anh Tran via Phabricator via lldb-commits]

kimanh added a comment.

Thanks a lot for the review! Very sorry for my late update, I was out on vacation and then had to catch up with mails. Updated the revision now.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:537
+    if (const llvm::DWARFUnitIndex::Entry *entry = m_header.GetIndexEntry()) {
+      const auto *contribution = entry->getContribution(llvm::DW_SECT_RNGLISTS);
+      if (!contribution) {
----------------
jankratochvil wrote:
> I have found this `getContribution` adjustment duplication, are there some reasons it is not unified?  https://www.jankratochvil.net/t/D107456-unify.patch
> The issue is the code then handles two different `.debug_rnglists` `DWARFDataExtractor`s with different offsets.
> 
Thanks a lot for the patch, I unified it in the latest update. IIRC (some time ago, so I don't recall completely) there was a mismatch in offsets maybe because I missed to update `GetRnglistOffset` to use `getRnglistData` too.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556
+          " (ranges list base: 0x%" PRIx64 "): %s",
+          offset, m_ranges_base, toString(table_or_error.takeError()).c_str());
   }
----------------
jankratochvil wrote:
> One such reason can be missing DWP absolute offset for the error report. That could be returned from `GetRnglistData()`.
> 
If I understand your comment correctly, you are suggesting to incorporate the contribution offset into the error message of `GetRnglistData`, is that correct? However, `GetRnglistData` will only return an error message if the contribution offset cannot be read, so the contribution offset cannot be specified in the error message (and thus the absolute offset cannot be inferred) . Or maybe I'm misunderstanding your comment here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107456/new/

https://reviews.llvm.org/D107456