[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Some nits but this LGTM, thanks! I'll accept & land this for you once the last few things are addressed :)



================
Comment at: lldb/tools/lldb-server/lldb-server.cpp:59
     display_usage(progname);
-    exit(option_error);
+    exit(1);
   }
----------------
`return 1;`


================
Comment at: lldb/tools/lldb-server/lldb-server.cpp:67
+    return main_gdbserver(argc, argv);
     break;
+  }
----------------
That break and the ones below are now dead code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108351/new/

https://reviews.llvm.org/D108351