[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

[Sebastian Schwartz via Phabricator via lldb-commits]

saschwartz added inline comments.


================
Comment at: lldb/tools/lldb-server/lldb-platform.cpp:324
       WithColor::error() << error.AsCString() << '\n';
-      exit(socket_error);
+      return socket_error;
     }
----------------
teemperor wrote:
> FWIW, `socket_error` seems to be just a (constant) `-1`? I think this could just be `return 1`.
Sounds fine, will change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108351/new/

https://reviews.llvm.org/D108351