[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 17 17:25:18 PDT 2021
clayborg added a comment.
Herald added a subscriber: JDevlieghere.
LGTM. Anyone else have any issues?
================
Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148
+ std::string proc_fd_path = "/proc/self/fd";
+ std::filesystem::path fp(proc_fd_path);
----------------
MaskRay wrote:
> /proc/self/fd is generally unavailable on non-Linux OSes.
which is why the "else" clause is still intact. If the file fails to open, we do what we did before.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105732/new/
https://reviews.llvm.org/D105732
More information about the lldb-commits
mailing list